[alsa-devel] Regression caused by "ASoC: core: Rework SOC_DOUBLE_R_SX_TLV add SOC_SINGLE_SX_TLV"

[Brian Austin]

On Mon, 10 Feb 2014, Thomas Petazzoni wrote:

> Dear Brian Austin,
>
> On Thu, 30 Jan 2014 11:23:57 -0600, Brian Austin wrote:
>
>>>>          SOC_DOUBLE_R_SX_TLV("Analog Playback Volume",
>>>>                          CS42L51_AOUTA_VOL, CS42L51_AOUTB_VOL,
>>>> -                       0, 0x34, 0xE4, aout_tlv),
>>>> +                       8, 0xffffff19, 0x18, aout_tlv),
>>>>          SOC_DOUBLE_R_SX_TLV("ADC Mixer Volume",
>>>>
>>>> shifting 8 on an 8bit register?
>>>
>>> These values are just the ones that were here before your commit
>>> 1d99f2436d0d1c7741d6dfd9d27b5376cdbbca40. I didn't invent anything,
>>> just reverted partially your commit.
>>>
>> Oh yes, of course. I was just making the comment that it looks very
>> strange to have that shift value. I'm glad it works for your system and
>> you can go forward with your development.
>>
>> Once I get it figured out, I'll CC you on the submission for your review
>> and test.
>
> Any news about this volume control problem on cs42l51 ?
>
> Thanks!
>
> Thomas
Hello Thomas,

I found the issue WRT the CS42L51. It was actually the shift values for 
the kcontrols were wrong :)

I have the changes and will be sending the patch shortly.  Your CC'd as 
reporter if that's OK.

Thanks,
Brian