[alsa-devel] [PATCH] ASoC: tegra: Use flat regcache.

Mark Brown broonie at kernel.org
Tue Mar 18 11:28:58 CET 2014


On Tue, Mar 18, 2014 at 07:46:09AM +0100, Takashi Iwai wrote:

> kmemdup() with GFP_KERNEL in the lock context.  Ditto in
> regmap_register_patch(), which calls krealloc() with GFP_KERNEL.

So send a patch...

> The former could be fixed by moving the lock like below.  The fix for
> the latter depends on whether we need to protect map->patch_regs
> growth from races or not.  If not, krealloc() can be moved out of the
> lock.

It should only be happening on init so probably not.  On the other hand
doing it without any sort of locking isn't great.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140318/15922252/attachment.sig>


More information about the Alsa-devel mailing list