[alsa-devel] [PATCH] ASoC: tlv320aic31xx: Staticise non-exported symbols

[Lars-Peter Clausen]

On 03/14/2014 09:09 AM, Jyri Sarha wrote:
> On 03/13/2014 07:48 PM, Mark Brown wrote:
>> From: Mark Brown <broonie at linaro.org>
>>
>> Signed-off-by: Mark Brown <broonie at linaro.org>
>
>
> Acked-by: Jyri Sarha <jsarha at it.com>
>
> /me has added one more thing to his patch sending check list.

What I typically try to do before submitting a patch is run

make C=2 .../driver.o
make C=2 CHECK=scripts/coccicheck .../driver.o
make C=2 CHECK="smatch --full-path -p=kernel" .../driver.o

that will typically catch these little mistakes. Also of course 
scripts/checkpatch.pl on the patch itself.

- Lars