[alsa-devel] [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation

[Jyri Sarha]

On 03/10/2014 06:05 PM, Jyri Sarha wrote:
> On 03/10/2014 05:47 PM, Mark Brown wrote:
>> On Mon, Mar 10, 2014 at 03:25:41PM +0200, Jyri Sarha wrote:
>>> On 03/10/2014 02:58 PM, Mark Brown wrote:
>>>> On Mon, Mar 10, 2014 at 10:52:21AM +0200, Jyri Sarha wrote:
> ...
>>
>>> I agreed on not to have it as the default. I can still imagine
>>> couple of reason to have this option around. For instance, if the
>>> board designer decides to pull the bias voltage from outside of the
>>> chip completely, or like in my test setup when I feed the mic input
>>> from a headset output of another device, because I do not have a
>>> microphone around ATM.
>>
>> To repeat what I said first time around in those cases the pin wouldn't
>> be connected at all so why would it ever be enabled?  You're not
>> specifying that it's going to be always enabled at a given voltage.
>>
>
> What ever. My laptop headset output does not seem to mind about bias
> voltage being fed to it. In the first case the pin wouldn't be connected
> so it does not matter. I'll remove the option.
>

Damn, I finally understood what you meant. I removed the explicit route 
to MICBIAS from the codec driver and left it to be added by a machine 
driver. Also removed all references to MIBIAS_OFF DT parameter.

Best regards,
Jyri