[alsa-devel] [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation

[Mark Brown]

On Mon, Mar 10, 2014 at 03:25:41PM +0200, Jyri Sarha wrote:
> On 03/10/2014 02:58 PM, Mark Brown wrote:
> >On Mon, Mar 10, 2014 at 10:52:21AM +0200, Jyri Sarha wrote:

> >>>+- ai31xx-micbias-vg - MicBias Voltage setting
> >>>+        0 or MICBIAS_OFF - MICBIAS output it not powered

> >So, on every other version of this patch set I've suggested removing
> >this as there's no reason why the bias would be wired up but disabled.
> >Each time you seem to agree that the option should be removed yet here
> >it is again...

> I agreed on not to have it as the default. I can still imagine
> couple of reason to have this option around. For instance, if the
> board designer decides to pull the bias voltage from outside of the
> chip completely, or like in my test setup when I feed the mic input
> from a headset output of another device, because I do not have a
> microphone around ATM.

To repeat what I said first time around in those cases the pin wouldn't
be connected at all so why would it ever be enabled?  You're not
specifying that it's going to be always enabled at a given voltage.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140310/c53778a3/attachment.sig>