[alsa-devel] [PATCH 08/39] firewire-lib: Add support for duplex streams synchronization in blocking mode

[Takashi Sakamoto]

(Mar 3 2014 05:55), Clemens Ladisch wrote:
> This pointer does not report any actual error code either.

OK. I use NULL instead of this.

> Why this change in this patch?

It's my mistake and should be removed.

> It might be easier to check just s->sync_slave instead of multiple flags.
>
>Same here.

Hm. But s->sync_slave->callbacked is also needed. So:

###
if (s->sync_slave && s->sync_slave->callbacked)
###

> This name is rather generic; this is not "the" callback, but the
> "initial" or "first" callback.

OK. I use "amdtp_stream_first_callback" instead of "amdtp_stream_callback".

> This is not necessary here.

Exactly.

> This needs to be done only if sync_mode != CIP_SYNC_TO_DEVICE.

OK.


Regards

Takashi Sakamoto
o-takashi at sakamocchi.jp