[alsa-devel] [PATCH v2 1/4] ASoC: tlv320aic31xx: Add basic codec driver implementation

[Jyri Sarha]

On 03/09/2014 10:12 AM, Mark Brown wrote:
> On Fri, Mar 07, 2014 at 02:53:15PM +0200, Jyri Sarha wrote:
>> On 03/05/2014 03:55 AM, Mark Brown wrote:
>
>>>> +	/* Mic Bias */
>>>> +	SND_SOC_DAPM_SUPPLY("Mic Bias", SND_SOC_NOPM, 0, 0, mic_bias_event,
>>>> +			    SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),
>
>>> The idiomatic thing would be to use the pin name.
>
>> In this case the mic bias comes out of the chip trough a separate
>> pin and it is up to board designer to connect it with any (or all)
>> of the three mic pins.
>
> Yes, exactly - you should be using the name of the pin that supplies the
> bias.  This is how essentially all microphone biases work.
>

Changed widget name from "Mic Bias" to "MICBIAS".

BR,
Jyri