[alsa-devel] [PATCH v3] ASoC: davinci-evm: Add AM43xx-EPOS-EVM audio support

[Mark Brown]

On Tue, Mar 04, 2014 at 05:43:51PM +0200, Jyri Sarha wrote:
> Add machine driver support for AM43xx-ePOS-EVM and update associated
> device tree binding document.

Don't send new patches in replies to the middle of threads, that is just
confusing and hard to follow.  Send a new series.

> +/* Logic for EVMs with an aic31xx */
> +static int evm_aic31xx_init(struct snd_soc_pcm_runtime *rtd)
> +{
> +	struct snd_soc_codec *codec = rtd->codec;
> +	struct snd_soc_card *card = rtd->card;
> +	struct snd_soc_dapm_context *dapm = &card->dapm;
> +	struct device_node *np = card->dev->of_node;
> +	int ret;
> +
> +	snd_soc_dapm_new_controls(dapm, aic31xx_dapm_widgets,
> +				  ARRAY_SIZE(aic31xx_dapm_widgets));
> +
> +	if (np) {
> +		ret = snd_soc_of_parse_audio_routing(codec->card,
> +						     "ti,audio-routing");
> +		if (ret)
> +			return ret;
> +	}

Why not add the DAPM widget table to...

> +	{
> +		.compatible = "ti,am43xx-epos-evm-audio",
> +		.data = &evm_dai_tlv320aic3111,
> +	},

...the data here?

Or alternatively should support for the widgets binding that was
recently added by added to the kernel - that way the binding becomes
more general and doesnn't need individual boards adding?  Indeed ideally
the simple-card binding (which that was added for) could just be used
for these boards.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140305/b5464305/attachment.sig>