[alsa-devel] [PATCH RFC 3/5] ASoC: tlv320aic31xx: Add DT binding document

[Mark Brown]

On Wed, Feb 26, 2014 at 11:14:27AM +0200, Jyri Sarha wrote:

> +- ai31xx-micbias-vg - MicBias Voltage required.
> +	1 - MICBIAS output is powered to 2.0V,
> +	2 - MICBIAS output is powered to 2.5V,
> +	3 - MICBIAS output is connected to AVDD,
> +	If this node is not mentioned or if the value is incorrect, then MicBias
> +	is powered down.

Please provide defines for these as part of the binding.  It's not clear
to me why leaving the micbias powered down is a sane default, it'll only
be powered up if it's connected to something and used which doesn't seem
altogether sane.  I'd suggest picking 2.0V (the lowest voltage so least
likely to cause damage).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140303/6a733a5e/attachment.sig>