[alsa-devel] [PATCH 06/19] ASoC: rsnd: add .set_sysclk on snd_soc_dai_ops

Kuninori Morimoto kuninori.morimoto.gx at gmail.com
Mon Mar 3 03:12:03 CET 2014


Hi Mark again

> > > This patch adds struct snd_soc_dai_ops :: set_sysclk.
> > > But, it do nothing, since rsnd sysclk is controlled by ADG.
> > > Without this patch, simple-card init will be failed
> > > if DT case.
> > 
> > We should fix the simple-card code so that it does not need this rather
> > than adding empty functions to all the drivers - I'd expect it to handle
> > -ENOTSUPP as not an error.
> 
> Ahh...
> 
> Current simple-card will get sysclk absolutely in normal (?) way.
> Can you see end of asoc_simple_card_sub_parse_of() ?
> 
> rsnd got sysclk from it, but it is "module" clock, not "sysclk".
> 
> I guess I can avoid this issue if dtsi has
> 
> 	system-clock-frequency = 0;
> 
> but it is strange.

Oops, I was misunderstanding.
I see, I will add -ENOTSUPP support.



More information about the Alsa-devel mailing list