[alsa-devel] [PATCH] ASoC: add RT5670 CODEC driver

[Mark Brown]

On Mon, Jun 30, 2014 at 05:38:59AM +0000, Bard Liao wrote:

> > > +static int check_dac_monor_asrc_source(struct snd_soc_dapm_widget
> > *source,
> > > +			 struct snd_soc_dapm_widget *sink) {
> > > +	struct snd_soc_codec *codec = source->codec;
> > > +
> > > +	return is_using_asrc(codec, RT5670_ASRC_2, 4); }

> > I have to say I'm not convinced all these wrapper functions are really
> > adding much - just making is_using_asrc() take a widget and passing the
> > arguments directly seems as simple.

> Do you mean use is_using_asrc() as the checking function for all of those
> widgets, and use different arguments for different widgets?

Yes, it seems like that's all the functions do which isn't adding much.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140630/b4d0065e/attachment.sig>