[alsa-devel] [PATCH 4/4 v2] regulator: arizona-ldo1: Do not control clocking from regulator

[Charles Keepax]

On Sat, Jun 21, 2014 at 09:53:49PM +0100, Mark Brown wrote:
> On Fri, Jun 20, 2014 at 03:41:13PM +0100, Charles Keepax wrote:
> > From: Richard Fitzgerald <rf at opensource.wolfsonmicro.com>
> > 
> > Using the driver for the internal regulator to also control
> > the clock frequency of blocks inside the codec is an
> > unexpected side-effect for a regulator, and also means that
> > the core clocks won't be changed as expected if an external
> > regulator is used to power the codec.
> > 
> > The clocking control is now handled by the core arizona MFD
> > driver so can be removed from the LDO1 driver.
> 
> I would expect this to be squashed into the first patch since otherwise
> there's a bisection issue with both drivers trying to maintain the same
> thing at the same time.

Whilst there are two things controlling it for a couple of
patches they both set the same value one after another, so it
should be safe. If it goes into the first patch nothing is
controlling the DVFS for a few patches so that actually creates a
bisection issue. It could be squashed into the second last patch
but this way feels cleaner?

Thanks,
Charles