[alsa-devel] [PATCH v2 2/3] ASoC: add es8328 codec driver

[Sean Cross]

On 06/17/14 14:24, Lars-Peter Clausen wrote:
> On 06/17/2014 07:16 AM, Sean Cross wrote:
>
> A couple of small bits inline.
[...]
> [...]
>> +
>> +/*
>> + * ES8328 Controls
>> + */
>> +
>> +static const char * const deemph_txt[] = {"None", "32Khz",
>> "44.1Khz", "48Khz"};
>> +static SOC_ENUM_SINGLE_DECL(deemph,
>> +                ES8328_DACCONTROL6, 6, deemph_txt);
>
> deemph should just be a single boolean switch (On or Off) and
> automatically select the correct setting based on the configured
> sample rate.
Seems like a lot of work.  Is there an example of how this should be
written?  What should the behavior be when deemph is enabled, and output
is, say, 22.050 kHz (which doesn't have a deemph supported in
hardware)?  Should selection of the deemph register be performed inside
hw_params()?

I'll incorporate the other fixes for v3.


Sean