[alsa-devel] ASoC: rsnd: care DMA slave channel name for DT
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Wed Jun 11 02:59:03 CEST 2014
Hi Dan
Thank you for your feedback
> 294 */
> 295 mod[0] = NULL; /* for "mem" */
>
> We memset everything to NULL in the loop above so this isn't needed.
Ahh... indeed.
Thank you. I will send patch for it
> 313 if (is_play) {
> 314 src_mod = mod[index - 1];
> 315 dst_mod = mod[index];
> 316 } else {
> 317 src_mod = mod[index];
> 318 dst_mod = mod[index + 1];
>
> So then it complains that mod[] has only MOD_MAX elements so we're one
> space past the end of the array. Probably the way this is called, there
> is something to prevent it?
Grr...
318 line should be
- dst_mod = mod[index + 1];
+ dst_mod = mod[index - 1];
Thank you for your check.
I will send patch for it.
More information about the Alsa-devel
mailing list