[alsa-devel] [PATCH 5/6] fireworks: Remove meaningless mutex_unlock()
Takashi Iwai
tiwai at suse.de
Wed Jun 4 14:41:02 CEST 2014
At Wed, 4 Jun 2014 15:25:36 +0900,
Takashi Sakamoto wrote:
>
> Currently mutex_unlock() is called in module's cleanup function. But after
> cleaned up, this mutex is automatically released. So this function call
> is meaningless.
>
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
It must be meant as mutex_destroy()?
I applied it with the typo fixes. Thanks.
Takashi
> ---
> sound/firewire/fireworks/fireworks.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
> index 996fdc4..3e2ed8e 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -346,7 +346,6 @@ static void __exit snd_efw_exit(void)
> {
> snd_efw_transaction_unregister();
> driver_unregister(&efw_driver.driver);
> - mutex_destroy(&devices_mutex);
> }
>
> module_init(snd_efw_init);
> --
> 1.8.3.2
>
More information about the Alsa-devel
mailing list