[alsa-devel] [PATCH 4/6] fireworks: Remove a constant over width to which it's applied

Takashi Iwai tiwai at suse.de
Wed Jun 4 14:40:02 CEST 2014


At Wed,  4 Jun 2014 15:25:35 +0900,
Takashi Sakamoto wrote:
> 
> The constants of enum snd_efw_grp_type is for struct snd_efw_phys_grp.type.
> But this member is 1 byte. Although the value is between 0x00-0xff, a constant
> has 0x10000. This constant is meaningless.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Applied, thanks.


Takashi

> ---
>  sound/firewire/fireworks/fireworks.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/firewire/fireworks/fireworks.h b/sound/firewire/fireworks/fireworks.h
> index d2b36be..4f0201a 100644
> --- a/sound/firewire/fireworks/fireworks.h
> +++ b/sound/firewire/fireworks/fireworks.h
> @@ -162,7 +162,6 @@ enum snd_efw_grp_type {
>  	SND_EFW_CH_TYPE_GUITAR			= 7,
>  	SND_EFW_CH_TYPE_PIEZO_GUITAR		= 8,
>  	SND_EFW_CH_TYPE_GUITAR_STRING		= 9,
> -	SND_EFW_CH_TYPE_VIRTUAL			= 0x10000,
>  	SND_EFW_CH_TYPE_DUMMY
>  };
>  struct snd_efw_phys_meters {
> -- 
> 1.8.3.2
> 


More information about the Alsa-devel mailing list