[alsa-devel] [PATCH 3/6] fireworks: Improve comments about Fireworks transaction

Takashi Iwai tiwai at suse.de
Wed Jun 4 14:39:52 CEST 2014


At Wed,  4 Jun 2014 15:25:34 +0900,
Takashi Sakamoto wrote:
> 
> It includes descriptions to cause misreading.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Applied, thanks.


Takashi

> ---
>  sound/firewire/fireworks/fireworks_transaction.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/firewire/fireworks/fireworks_transaction.c b/sound/firewire/fireworks/fireworks_transaction.c
> index a6a9e9f..255dabc 100644
> --- a/sound/firewire/fireworks/fireworks_transaction.c
> +++ b/sound/firewire/fireworks/fireworks_transaction.c
> @@ -8,19 +8,19 @@
>  
>  /*
>   * Fireworks have its own transaction. The transaction can be delivered by AV/C
> - * Vendor Specific command. But at least Windows driver and firmware version 5.5
> - * or later don't use it.
> + * Vendor Specific command frame or usual asynchronous transaction. At least,
> + * Windows driver and firmware version 5.5 or later don't use AV/C command.
>   *
>   * Transaction substance:
> - *  At first, 6 data exist. Following to the 6 data, parameters for each
> - *  commands exists. All of parameters are 32 bit alighed to big endian.
> + *  At first, 6 data exist. Following to the data, parameters for each command
> + *  exist. All of the parameters are 32 bit alighed to big endian.
>   *   data[0]:	Length of transaction substance
>   *   data[1]:	Transaction version
>   *   data[2]:	Sequence number. This is incremented by the device
> - *   data[3]:	transaction category
> - *   data[4]:	transaction command
> - *   data[5]:	return value in response.
> - *   data[6-]:	parameters
> + *   data[3]:	Transaction category
> + *   data[4]:	Transaction command
> + *   data[5]:	Return value in response.
> + *   data[6-]:	Parameters
>   *
>   * Transaction address:
>   *  command:	0xecc000000000
> -- 
> 1.8.3.2
> 


More information about the Alsa-devel mailing list