[alsa-devel] [RFC] [PATCH] firewire-lib: Use IEC 61883-6 compliant labels for Raw Audio/

[Takashi Iwai]

At Sat, 31 May 2014 16:51:52 +0900,
Takashi Sakamoto wrote:
> 
> (May 31 2014 16:35), Clemens Ladisch wrote:
> > Takashi Sakamoto wrote:
> >> I don't touch this label issue with my patchset because there is a bit
> >> possibility to cause a regression. But now, I have a confidence that
> >> this modification is reasonable. In detail, please see an attached patch.
> > 
> >> According to AM824 in IEC 61883-6:2002, 2 bits in LSB of label for Raw Audio
> >> data means Valid Length Code (VBL). Ths value is:
> >> - b00 for 24 bits sample (label is 0x40)
> >> - b01 for 20 bits sample (label is 0x41)
> >> - b10 for 16 bits sample (label is 0x42)
> >>
> >> But current firewire-lib apply 24 bits label for both of 16/24 bits samples.
> >>
> >> As long as I investigate with BeBoB/Fireworks and OXFW, all of them have a
> >> behaviour to ignore this label
> > 
> > Same for DICE.
> 
> It's nice information for Dice developers.
> 
> > Acked-by: Clemens Ladisch <clemens at ladisch.de>
> 
> Thanks.
> 
> Iwai-san, could you please apply this patch to for-next?

If you'd like it to be merged, just resend without RFC tag (and with
ack tags).


Takashi