[alsa-devel] [PATCH v2] ASoC: wm8962: Let CODEC driver enable and disable its own MCLK

[Mark Brown]

On Tue, Jul 29, 2014 at 10:55:19AM +0800, Nicolin Chen wrote:
> On Mon, Jul 28, 2014 at 03:19:43PM -0300, Fabio Estevam wrote:

> > >> +     pdata->mclk = devm_clk_get(&i2c->dev, NULL);

> > > This is broken for deferred probe.

> Sorry. I don't get why deferred probe would be broken by this.
> And I just took a test by adding this:

I don't see the code that actually pays attention to the return value
from devm_clk_get() - in the main probe function the code just treats
all errors as a missing MCLK.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140729/ec01f989/attachment.sig>