[alsa-devel] [PATCH] ASoC: rt286: request IRQ in soc level

[Mark Brown]

On Mon, Jul 28, 2014 at 04:08:43PM +0800, bardliao at realtek.com wrote:
> From: Bard Liao <bardliao at realtek.com>
> 
> We assign rt286->codec in rt286_probe. To prevent rt286->codec = NULL
> when rt286_irq is executed, it is better to request IRQ in rt286_probe
> instead of rt286_i2c_probe.

No, this is a step backwards - resources should be requested in the
device level probe not in the ASoC level probe.  It is better to make
the interrupt safe if it happens to be called before the card is ready.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140728/dca9deb3/attachment-0001.sig>