[alsa-devel] [PATCH 1/3] bebob: Fix a missing to unlock mutex in error handling case

Takashi Sakamoto o-takashi at sakamocchi.jp
Tue Jul 22 17:23:05 CEST 2014


(Jul 22 2014 23:26), Takashi Iwai wrote:
> BTW, at the next time, put "v2" or such in the subject line so that
> people can distinguish the new patch series from the previous ones.
> You can use --subject-prefix option for git-format-patch or else.

In this time I newly revised these patches, thus there was a lack of
patches in previous series. I thought it better to post them as a new
series.

But I should have added v2 for the series as you indicate.

> Preferably, write the changes since the previous revision, too
> (usually below the --- line, so that it's not merged into the git
>  changelog; some people like to have them in the final commit,
>  though.)

OK.

> Last but not least, don't forget to put a proper subject prefix.
> For ALSA codes, we put "ALSA:" prefix in the subject.  Study git
> changelogs.

Next time, I remember to add the prefix. In my repository, I use the
prefix to distinguish my local patches from upstream patches. But I
should change this workflow.


Regards

Takashi Sakamoto
o-takashi at sakamocchi.jp



More information about the Alsa-devel mailing list