[alsa-devel] [PATCH v2 11/13] ASoC: Intel: mrfld: add the DSP DAPM widgets

[Mark Brown]

On Thu, Jul 10, 2014 at 10:14:55AM +0530, Subhransu S. Prusty wrote:

> +	pr_debug("%s: widget = %s\n", __func__, w->name);
> +	for (i = 0; i < w->num_kcontrols; i++) {
> +		if (dapm_kcontrol_get_value(w->kcontrols[i])) {
> +			mc = (struct soc_mixer_control *)(w->kcontrols[i])->private_value;
> +			val |= 1 << mc->shift;
> +		}
> +	}

So, this is the usage of dapm_kcontrol_get_value() (quite a way away
from the patch exporting it!).  The usage here looks *very* strange.
We're calling the function but treating the result as a boolean and
manually decoding the DAPM data structures in order to get the control
shift...  that's odd to say the least.

> +	SST_FILL_DESTINATION(2, cmd.output_id,
> +			     ids->location_id, SST_DEFAULT_MODULE_ID);
> +	cmd.nb_inputs =	fill_swm_input(&cmd.input[0], val);

So what we're doing here is parsing the controls to get which inputs are
enabled...  it's not altogether clear to me that we shouldn't be doing
this at control update time.  Presumably we'll also need to be sending
these messages when the controls are updated to account for changes that
happen while streams are active.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140718/32e40374/attachment.sig>