[alsa-devel] [PATCH v4 0/6] Per-user clock constraints

Tomeu Vizoso tomeu.vizoso at collabora.com
Thu Jul 17 16:13:13 CEST 2014


Hi,

I'm retaking Rabin's patches [0] for splitting the clk API in two: one API for
clk consumers and another for providers. The consumer API uses a clk structure
that just keeps track of the consumer and has a reference to the actual
clk_core struct, which is used internally.

I have kept a patch from Rabin that aims to aid in debugging nested
enable/disable calls, though my personal aim is to allow more than one consumer
to influence the final, effective frequency rate. For now this is limited to
setting floor and ceiling constraints, with the short-term aim of allowing
devfreq and thermal drivers to set floor and ceiling frequencies on the memory
clock, respectively.

For those functions in the consumer clk API that were called from providers, I
have added variants to clk-provider.h that are the same only that accept a
clk_core instead. These functions are prefixed with clk_provider_.

Patch 1/6 just adds a bunch of defines with the goal of having all the renames
in their own commit while preserving git-bisectability, with patch 3/6
containing the rename itself as generated by the Coccinelle script in [1].
Patch 2/6 is needed because sound/soc/mxs/mxs-saif.c calls both the consumer
and the provider API. The actual implementation of the API split comes in patch
4/6. I will be happy to organize the refactoring differently if anybody has a
better idea.

Patch 5/6 warns when there's an unbalanced usage of the enable and disable
APIs, and patch 6/6 adds the API for setting floor and ceiling frequencies, per
consumer.

[0] http://thread.gmane.org/gmane.linux.kernel/1402006
[1] http://cgit.collabora.com/git/user/tomeu/linux.git/commit/?id=da9c7e34d9

Thanks,

Tomeu

Tomeu Vizoso (6):
  clk: Add temporary mapping to the existing API
  ASoC: mxs-saif: fix mixed use of public and provider clk API
  clk: Move all drivers to use internal API
  clk: use struct clk only for external API
  clk: per-user clock accounting for debug
  clk: Add floor and ceiling constraints to clock rates

[detailed diffstat omitted for brevity sake]

 244 files changed, 2345 insertions(+), 1812 deletions(-)

-- 
1.9.3



More information about the Alsa-devel mailing list