[alsa-devel] [PATCH 3/5] ALSA: revo: Remove unused variable

Takashi Iwai tiwai at suse.de
Tue Jul 1 14:04:54 CEST 2014


At Tue, 1 Jul 2014 17:30:22 +0530,
Sachin Kamat wrote:
> 
> On Tue, Jul 1, 2014 at 5:27 PM, Takashi Iwai <tiwai at suse.de> wrote:
> > At Tue,  1 Jul 2014 17:02:56 +0530,
> > Sachin Kamat wrote:
> >>
> >> 'err' is not used in the function. Remove it.
> >
> > Better to handle the error case than ignoring it.
> 
> A comment below the code says
> "/* error ignored; it's no fatal error */"
> 
> Hence, I removed it.

The comment is wrong, then :)
If kmalloc for such a size fails, it's usually in a very bad
situation.


Takashi


More information about the Alsa-devel mailing list