[alsa-devel] [PATCH 3/5] ALSA: revo: Remove unused variable
Takashi Iwai
tiwai at suse.de
Tue Jul 1 13:57:30 CEST 2014
At Tue, 1 Jul 2014 17:02:56 +0530,
Sachin Kamat wrote:
>
> 'err' is not used in the function. Remove it.
Better to handle the error case than ignoring it.
thanks,
Takashi
>
> Signed-off-by: Sachin Kamat <sachin.kamat at samsung.com>
> ---
> sound/pci/ice1712/revo.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c
> index 1112ec1953be..0168aaa5f58c 100644
> --- a/sound/pci/ice1712/revo.c
> +++ b/sound/pci/ice1712/revo.c
> @@ -481,7 +481,6 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice)
> static const unsigned char ak4114_init_txcsb[] = {
> 0x41, 0x02, 0x2c, 0x00, 0x00
> };
> - int err;
>
> struct revo51_spec *spec;
> spec = kzalloc(sizeof(*spec), GFP_KERNEL);
> @@ -489,7 +488,7 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice)
> return -ENOMEM;
> ice->spec = spec;
>
> - err = snd_ak4114_create(ice->card,
> + snd_ak4114_create(ice->card,
> ap192_ak4114_read,
> ap192_ak4114_write,
> ak4114_init_vals, ak4114_init_txcsb,
> --
> 1.7.9.5
>
More information about the Alsa-devel
mailing list