[alsa-devel] [PATCH 1/5] ALSA: hda: Remove unused variable

[Takashi Iwai]

At Tue,  1 Jul 2014 17:02:54 +0530,
Sachin Kamat wrote:
> 
> 'status' is not used in the function. Remove it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat at samsung.com>
> Cc: Stephen Warren <swarren at wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding at gmail.com>
> ---
> All patches in this series only compile tested.

Removing such a line is unsafe, thus it must be tested.  It changes
the hardware access pattern and sometimes the read is intentionally
there although the value isn't used.

That said, without testing, I won't apply such patches.


thanks,

Takashi


> ---
>  sound/pci/hda/hda_tegra.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
> index a366ba9293a8..8cd7b06eecef 100644
> --- a/sound/pci/hda/hda_tegra.c
> +++ b/sound/pci/hda/hda_tegra.c
> @@ -272,13 +272,9 @@ static int hda_tegra_resume(struct device *dev)
>  	struct snd_card *card = dev_get_drvdata(dev);
>  	struct azx *chip = card->private_data;
>  	struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip);
> -	int status;
>  
>  	hda_tegra_enable_clocks(hda);
>  
> -	/* Read STATESTS before controller reset */
> -	status = azx_readw(chip, STATESTS);
> -
>  	hda_tegra_init(hda);
>  
>  	azx_init_chip(chip, 1);
> -- 
> 1.7.9.5
>