[alsa-devel] [PATCH 2/2] ASoC: fsl: add imx-ssm2603 machine driver

[Philipp Zabel]

Hi Nicolin,

Am Donnerstag, den 30.01.2014, 13:46 +0800 schrieb Nicolin Chen:
> Hi Philipp,
> 
> On Wed, Jan 29, 2014 at 05:47:27PM +0100, Philipp Zabel wrote:
> > This adds support for i.MX boards with Analog Devices SSM2603 codecs
> > connected via I2S with separate Tx and Rx clocks.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> > ---
> >  sound/soc/fsl/Kconfig       |  12 +++
> >  sound/soc/fsl/Makefile      |   2 +
> >  sound/soc/fsl/imx-ssm2603.c | 239 ++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 253 insertions(+)
> >  create mode 100644 sound/soc/fsl/imx-ssm2603.c
> > 
> > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> > index b7ab71f..8a4ff4e 100644
> > --- a/sound/soc/fsl/Kconfig
> > +++ b/sound/soc/fsl/Kconfig
> > @@ -212,4 +212,16 @@ config SND_SOC_IMX_MC13783
> >  	select SND_SOC_MC13783
> >  	select SND_SOC_IMX_PCM_DMA
> >  
> > +config SND_SOC_IMX_SSM2603
> > +	tristate "SoC Audio support for i.MX boards with ssm2603"
> > +	depends on OF && I2C
> > +	select SND_SOC_SSM2602
> > +	select SND_SOC_IMX_PCM_DMA
> > +	select SND_SOC_IMX_AUDMUX
> > +	select SND_SOC_FSL_SSI
> > +	select SND_SOC_FSL_UTILS
> 
> Not sure if this UTILS is essential...
> 
> > +static int imx_ssm2603_probe(struct platform_device *pdev)
> > +{
> > +	ret = snd_soc_register_card(&data->card);
> 
> devm_ might be better?

right, I'll change both.

thanks
Philipp