[alsa-devel] [PATCH v4 07/19] ALSA: Oxygen: Add new CS4245 SPI functions

[Mark Brown]

On Fri, Jan 24, 2014 at 04:18:08PM +0400, Roman Volkov wrote:
> Add the new SPI write and read functions. The SPI read function
> is used for creating initial registers dump and may be used for
> debugging purposes. SPI operations are cached, so there is a new
> function to manage the cache (shadow). I have to remove
> the shift from the CS4245_SPI_* constants, since when
> we are performing the reading, we need to shift by 8 instead
> of 16.

I can't help but think that this driver ought to be making more use of
frameworks - it sounds like an ASoC system really (split CODEC and CPU)
and all this register I/O stuff sounds like it could make use of regmap.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140124/928e4eb9/attachment.sig>