[alsa-devel] [PATCH 1/7] ASoC: Samsung: Fix build regressions due to gpio re-org

[Sachin Kamat]

On 22 January 2014 13:26, Linus Walleij <linus.walleij at linaro.org> wrote:
> On Wed, Jan 22, 2014 at 7:13 AM, Sachin Kamat <sachin.kamat at linaro.org> wrote:
>
>> Recent changes through commits c67d0f29262b ("ARM: s3c24xx: get rid
>> of custom <mach/gpio.h>"), b0161caa72b6 ("ARM: S3C[24|64]xx: move includes
>> back under <mach/> scope"), 364374121b78 ("ARM: s3c24xx: explicit
>> dependency on <plat/gpio-cfg.h>") and 41c3548e6da6 ("ARM: s3c64xx: get rid
>> of custom <mach/gpio.h>") caused build regressions due to broken
>> dependencies. Fix the following errors by including the necessary header
>> files explicitly:
>>
>> sound/soc/samsung/h1940_uda1380.c:56:3: error: implicit declaration of function ‘S3C2410_GPG’
>> sound/soc/samsung/h1940_uda1380.c:149:18: error: ‘S3C_GPIO_END’ undeclared (first use in this function)
>> sound/soc/samsung/h1940_uda1380.c:234:21: error: ‘S3C_GPIO_END’ undeclared (first use in this function)
>> sound/soc/samsung/h1940_uda1380.c:270:12: error: ‘S3C_GPIO_END’ undeclared (first use in this function)
>> sound/soc/samsung/neo1973_wm8753.c:239:2: error: implicit declaration of function ‘S3C2410_GPJ’
>> sound/soc/samsung/rx1950_uda1380.c:67:3: error: implicit declaration of function ‘S3C2410_GPG’
>> sound/soc/samsung/s3c2412-i2s.c:86:2: error: implicit declaration of function ‘s3c_gpio_cfgall_range’
>> sound/soc/samsung/s3c2412-i2s.c:86:2: error: implicit declaration of function ‘S3C2410_GPE’
>> sound/soc/samsung/s3c2412-i2s.c:86:2: error: implicit declaration of function ‘S3C_GPIO_SFN’
>> sound/soc/samsung/s3c2412-i2s.c:87:10: error: ‘S3C_GPIO_PULL_NONE’ undeclared
>> sound/soc/samsung/s3c24xx-i2s.c:394:2: error: implicit declaration of function ‘s3c_gpio_cfgall_range’
>> sound/soc/samsung/s3c24xx-i2s.c:394:2: error: implicit declaration of function ‘S3C2410_GPE’
>> sound/soc/samsung/s3c24xx-i2s.c:394:2: error: implicit declaration of function ‘S3C_GPIO_SFN’
>> sound/soc/samsung/s3c24xx-i2s.c:395:10: error: ‘S3C_GPIO_PULL_NONE’ undeclared
>> sound/soc/samsung/smartq_wm8987.c:112:3: error: implicit declaration of function ‘S3C64XX_GPL’
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
>> Cc: Linus Walleij <linus.walleij at linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
>
> And I *really* tried to catch all these, could we make this driver
> part of the defconfig
> if it isn't?

They aren't enabled by default. But makes sense to have them enabled
for better compile coverage.

-- 
With warm regards,
Sachin