[alsa-devel] [PATCH v3 08/16] ALSA: Oxygen: Add new CS4245 SPI functions
Clemens Ladisch
clemens at ladisch.de
Sat Jan 18 11:36:14 CET 2014
Roman Volkov wrote:
> +int cs4245_shadow_control(struct oxygen *chip, enum cs4245_shadow_operation op)
> +{
> + unsigned char addr;
> + int ret;
> +
> + for (addr = 1; addr < ARRAY_SIZE((((struct dg *)0)->cs4245_shadow));
> + addr++) {
This looks ugly (and there's one pair of parentheses too many). Just
include the line "struct dg *data = chip->model_data;" in this function.
Regards,
Clemens
More information about the Alsa-devel
mailing list