[alsa-devel] [PATCH 3/4] ASoC: tlv320aic32x4: DT support

[Mark Brown]

On Thu, Jan 16, 2014 at 04:30:26PM +0100, Markus Pargmann wrote:

> +Optional properties:
> + - ti,ldo-enable: Bool, has to be set when the codec is powered only through the
> +   LDOIN pin.

This seems very odd.  Should the regulator bindings not be being used
for this, either having a regulator in the device that's bound via the
DT or using regulator_get_optional() to check for the other supplies
that might be used being provided?

> + - gpio-reset - gpio pin number used for codec reset

This should be a standard GPIO specifier.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140117/8d0d1717/attachment.sig>