[alsa-devel] [PATCH 1/2] ASoC: DPCM: make some DPCM API calls non static for compressed usage

[Takashi Iwai]

At Thu, 16 Jan 2014 20:10:42 +0530,
Vinod Koul wrote:
> 
> On Thu, Jan 16, 2014 at 12:31:53PM +0000, Mark Brown wrote:
> > On Wed, Jan 15, 2014 at 04:51:56PM +0000, Liam Girdwood wrote:
> > > The ASoC compressed code needs to call the internal DPCM APIs in order to
> > > dynamically route compressed data to different DAIs.
> > 
> > Applied, thanks.  I'm holding off on the second patch for a little so
> > Vinod has a chance to say something since it's compressed stuff.
> Both look good to me, so
> 
> Acked-by: Vinod Koul <vinod.koul at intel.com>
> 
> The second patch still needs an update for properly copying the hw_params. This
> was one of issue reported by qcom folks, but I don't want to hold these now. We
> can fix that as it will impact systems not have fixup function for BEs.

One thing that makes me a bit nervous is that it's accessing the
actual PCM object.  So far, sound/pcm.h is included there just because
it's re-using the same enum definitions, etc, but it doesn't mean that
it allows accessing a PCM object or function.

If we bind a real PCM instance there, we should add the Kconfig
selection for SND_PCM from SND_COMPRESS_OFFLOAD.


Takashi