[alsa-devel] [PATCH 2/2] ASoC: codec doc, tlv320aic3x: Add tlv320aic32x4 as compatible

[Markus Pargmann]

Hi,

On Mon, Jan 13, 2014 at 03:44:57PM +0000, Mark Brown wrote:
> On Mon, Jan 13, 2014 at 02:18:28PM +0100, Markus Pargmann wrote:
> > On Mon, Jan 13, 2014 at 12:37:21PM +0000, Mark Brown wrote:
> 
> > > Applied, thanks but you should really also add this compatible string to
> > > the driver.
> 
> > Oh, I didn't notice that the 320aic3x driver actually has of_device_ids.
> > I was using the 320aic3x4 driver which only defines i2c_device_id but it
> > still matches with the compatible fields from my devicetree.
> 
> > So perhaps it is better to drop this patch as it is no explicit
> > compatible in the driver?
> 
> Or you could add the compatible string to the driver as I suggested...
> I don't see any reason for the device not to have a compatible string?

The codec is not working here at the moment, so I can't test if the
aic3204 codec is really working with the aic3x driver.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |