[alsa-devel] [PATCH] ASoC: da9055: Partially fix device

Opensource [Adam Thomson] Adam.Thomson.Opensource at diasemi.com
Thu Jan 9 12:30:42 CET 2014


On Wed,  8 Jan 2014 20:38:55 +0000, Mark Brown wrote:

> It has never been possible to even load the da9055 driver since both the
> MFD and CODEC drivers register the I2C device "da9055". Fix this by using
> the usual pattern for MFDs with multiple I2C addresses and having the CODEC
> driver reference an I2C dummy registered by the MFD.

> Since I don't know which I2C address to use for the CODEC a FIXME has been
> left in the MFD, this doesn't make anything any worse since the device has
> never been able to load in the first place.

What you're saying here is incorrect, as previously discussed at length in this thread:

http://mailman.alsa-project.org/pipermail/alsa-devel/2013-September/066027.html

The two drivers did work together fine until someone in 3.12 changed the PMIC I2C Id
back to just 'da9055' and broke it again. Also, I wanted to add a simple patch to tidy up
the I2C Id names and avoid this but you would not agree. The codec part can be
standalone and by doing what you've done here means that customers would need to
now add additional, unnecessary code to be able to use just the codec driver.
This is not right to me.
 


More information about the Alsa-devel mailing list