[alsa-devel] [PATCH v2] ASoC: soc-core: add snd_soc_of_parse_master_clkdir() for dt

[Li.Xiubo at freescale.com]

> Subject: Re: [PATCH v2] ASoC: soc-core: add snd_soc_of_parse_master_clkdir()
> for dt
> 
> On Thu, Jan 02, 2014 at 10:48:25AM +0800, Xiubo Li wrote:
> > This patch adds snd_soc_of_parse_master_clkdir() and supports below
> > style on dt:
> >
> > master-clkdir-out;
> >
> > If this property is absent 0 will be returned, 1 otherwise.
> > 0 : SND_SOC_CLOCK_IN
> > 1 : SND_SOC_CLOCK_OUT
> 
> This is mostly OK code wise, though it would be good to use those
> constants in the code.  However I'm still not sure about it being a good
> idea - it's similar issues to those with clock IDs but less strong.  Do
> you have a user in mind?

Yes, for the SAI & SGTL5000 DAIs and the existing fsl_ssi.c driver, etc. For
SSI DAI device, it will depend on the sysclk directions to do the different
clock settings.

For the VF610 series, the SAI will provide the clock to SGTL5000 Codec. Using
the simple audio card driver, I must set the CPU and CODEC DAI sysclk dir
values differently.

I will send one simple audio card's use case based SAI & SGTL5000 later.

Thanks,

--
Best Regards,
Xiubo