[alsa-devel] [PATCH 01/15] ASoC: fsl-ssi: Use regmap

[Markus Pargmann]

Hi,

On Thu, Feb 27, 2014 at 02:08:45AM +0000, Li.Xiubo at freescale.com wrote:
> 
> > @@ -134,6 +115,15 @@ struct fsl_ssi_rxtx_reg_val {
> >  	struct fsl_ssi_reg_val rx;
> >  	struct fsl_ssi_reg_val tx;
> >  };
> > +static const struct regmap_config fsl_ssi_regconfig = {
> > +	.max_register = CCSR_SSI_SACCDIS,
> > +	.reg_bits = 32,
> > +	.val_bits = 32,
> > +	.reg_stride = 4,
> > +#ifdef PPC
> > +	.val_format_endian = REGMAP_ENDIAN_BIG,
> > +#endif
> 
> Is this really needed for your PPC platforms?

I don't know if this is necessary. I don't have any PPC hardware where I
could test this driver. This is just a guess how regmap for this driver
and PPC should look like based on the previous code. So it would be
great if anyone could test this regmap config on PPC.

Thanks,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140227/d03bbcd4/attachment.sig>