[alsa-devel] [PATCH v4 0/7] ASoC: add CSR SiRFSoC sound drivers

Takashi Iwai tiwai at suse.de
Thu Feb 27 09:09:21 CET 2014


At Thu, 27 Feb 2014 13:38:56 +0900,
Mark Brown wrote:
> 
> On Wed, Feb 26, 2014 at 07:35:12AM +0100, Takashi Iwai wrote:
> 
> > Are there anything else you want to say except for these subject
> > lines?  The empty changelog for such big changes doesn't look good.
> 
> For new drivers it's more acceptable, though - if the driver isn't doing
> anything exciting (and a lot of them won't be) there's often not much to
> say.  A lot of the changelogs you see are just a bit of the marketing
> blurb from the datasheet.

True, but it may be still useful for reviewing.  At least, you can
know the expected hardware features provided by the driver in the
changelog before you start reviewing.  Otherwise you have no clue
whether it's implementing the right thing.


Takashi


More information about the Alsa-devel mailing list