[alsa-devel] [PATCHv2] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

Jarkko Nikula jarkko.nikula at linux.intel.com
Wed Feb 26 14:31:46 CET 2014


Some kernel configurations can cause following build error:

sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
  memcpy_fromio(&fw_tstamp,
  ^
cc1: some warnings being treated as errors

Fix this by including <linux/io.h> explicitly.

Reported-by: kbuild test robot <fengguang.wu at intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula at linux.intel.com>
---
v2: including <linux/io.h> instead of <asm/io.h>. Thanks to Takashi Iwai for
noticing (checkpatch.pl tells it too).

Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using
memcpy_fromio/_toio but there <asm/io.h> seems to come via
<linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.
---
 sound/soc/intel/sst-baytrail-ipc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/sst-baytrail-ipc.c b/sound/soc/intel/sst-baytrail-ipc.c
index 8c91a68b90bc..c12e194bbc6b 100644
--- a/sound/soc/intel/sst-baytrail-ipc.c
+++ b/sound/soc/intel/sst-baytrail-ipc.c
@@ -26,6 +26,7 @@
 #include <linux/platform_device.h>
 #include <linux/kthread.h>
 #include <linux/firmware.h>
+#include <linux/io.h>
 #include <asm/div64.h>
 
 #include "sst-baytrail-ipc.h"
-- 
1.8.5.3



More information about the Alsa-devel mailing list