[alsa-devel] [PATCH 1/6] ASoC: Intel: Add support for Haswell/Broadwell DSP

[Mark Brown]

On Thu, Feb 20, 2014 at 09:48:42PM +0000, Liam Girdwood wrote:
> Add support for low level differentiation functions for Haswell and Broadwell
> SST DSPs. This includes suppoprt for DSP boot and reset, DSP firmware module
> parsing and DSP memory block map initialisation.

Applied, thanks.  Some terribly minor things below:

> +u32 sst_shim32_read(void __iomem *addr, u32 offset)
> +{
> +	return readl(addr + offset);
> +}
> +EXPORT_SYMBOL_GPL(sst_shim32_read);

This lot all look like a regmap to me, though some extensions may be
needed for the 64 bit variants!

> +struct sst_ops haswell_ops = {
> +	.reset = hsw_reset,
> +        .boot = hsw_boot,
> +	.write = sst_shim32_write,

Something appears funky with the indentation for .boot - tab/space
confusion?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140221/ee132ae4/attachment.sig>