[alsa-devel] [PATCH] ASoC: Intel: Make sure we only build SST drivers on X86

Takashi Iwai tiwai at suse.de
Wed Feb 19 16:21:05 CET 2014


At Thu, 20 Feb 2014 00:00:40 +0900,
Mark Brown wrote:
> 
> On Wed, Feb 19, 2014 at 02:06:24PM +0000, Liam Girdwood wrote:
> > Disable build on non X86 architectures. This fixes the following build
> > errors on PPC :-
> 
> > sound/soc/intel/sst-dsp.c: In function 'sst_dsp_outbox_write':
> > sound/soc/intel/sst-dsp.c:218:2: error: implicit declaration of function 'memcpy_toio' [-Werror=implicit-function-declaration]
> >   memcpy_toio(sst->mailbox.out_base, message, bytes);
> >   ^
> 
> But lots of architectures do actually have these operations, I suspect
> looking at some of the existing users depending on PCI is enough if
> excessively strict (this will improve build coverage which tends to be
> useful even if the driver can't be run).

Yes.  I guess including linux/io.h should fix the build issue.

Though, limiting the build to X86 isn't bad particularly for this
driver.


Takashi


More information about the Alsa-devel mailing list