[alsa-devel] [PATCH 1/2] ASoC: fsl-spdif: big-endian support

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Tue Feb 11 08:25:25 CET 2014


> > +	spdif_priv->big_endian = of_property_read_bool(np, "big-endian");
> > +	if (spdif_priv->big_endian)
> > +		fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
> 
> Why not just:
> 	if (of_property_read_bool(np, "big-endian"))
> 		fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
>

I just think maybe other places of the driver maybe use this.
Yes, it could be removed just for now.

See the next version please.

Thanks very much,

--
Best Regards,
Xiubo



More information about the Alsa-devel mailing list