[alsa-devel] [PATCH v2 3/8] mfd: da9055: Add DT support for PMIC

Opensource [Adam Thomson] Adam.Thomson.Opensource at diasemi.com
Fri Feb 7 16:45:11 CET 2014


On Fri, Feb 07, 2014 at 11:03:18AM +0000, Lee Jones wrote:

> 
> Can you break this up please.
> 
> Bindings should be separate to the binding document.

Right, fine. Figured as they were directly related they should be in one patch
but will separate them.

> Entangling the i2c_device_id table with the of_device_id table sounds
> a bit too wacky for my liking. Where do you even use it?
> 

You're right. Is not used so can remove it.


More information about the Alsa-devel mailing list