[alsa-devel] [PATCH v2] MIDI driver for Behringer BCD2000 USB device

[Takashi Iwai]

At Wed, 05 Feb 2014 23:32:23 +0100,
Daniel Mack wrote:
> 
> On 02/05/2014 09:10 PM, Mario Kicherer wrote:
> > This patch adds initial support for the Behringer BCD2000 USB DJ controller.
> > At the moment, only the MIDI part of the device is working, i.e. knobs,
> > buttons and LEDs.
> > 
> > I also plan to add support for the audio part, but I assume that this will
> > require more effort than the rather simple MIDI interface. Progress can be
> > tracked at https://github.com/anyc/snd-usb-bcd2000.
> > 
> > Changes since v1:
> >         - fixed the various code style issues, thanks to Daniel Mack and
> >           checkpatch.pl.
> 
> Hmm, we're getting there :) But I still see:
> 
> total: 571 errors, 6 warnings, 580 lines checked
> 
> Mostly due to:
> 
> ERROR: DOS line endings

This must depend how you extract the mail content.
I can save the mail as a Unix plain text, and checkpatch complains
only two:
================================================================
WARNING: quoted string split across lines
#400: FILE: sound/usb/bcd2000/bcd2000.c:255:
+			"%s (%p): usb_submit_urb() failed"
+			"ret=%d, len=%d\n", __func__, substream, ret, len);

WARNING: quoted string split across lines
#482: FILE: sound/usb/bcd2000/bcd2000.c:337:
+				"%s: usb_submit_urb() failed,"
+				"ret=%d: ", __func__, ret);

total: 0 errors, 2 warnings, 580 lines checked
================================================================

Actually, these two should be fixed.  Better to keep the string in a
single line than breaking 80 chars limit, in general.  This would make
it easier to work with grep.


Takashi