[alsa-devel] [PATCH] ASoC: tegra: Add platform driver for rt5677 audio codec

Anatol Pomozov anatol.pomozov at gmail.com
Mon Dec 29 14:25:59 CET 2014


Hi

On Fri, Dec 26, 2014 at 8:38 AM, Mark Brown <broonie at kernel.org> wrote:
> On Tue, Dec 23, 2014 at 11:29:01AM -0800, Anatol Pomozov wrote:
>
>> +static int tegra_rt5677_probe(struct platform_device *pdev)
>> +{
>> +     struct device_node *np = pdev->dev.of_node;
>> +     struct snd_soc_card *card = &snd_soc_tegra_rt5677;
>> +     struct tegra_rt5677 *machine;
>> +     int ret;
>> +
>> +#if defined(CONFIG_MODULES) && defined(MODULE)
>> +     request_module("snd_soc_tegra30_i2s");
>> +#endif
>
> What's this all about then?

Sorry, my question was not clear. I meant is it ok to put this
request_module() to upstream code? If not then just remove it before
merging my patch.


More information about the Alsa-devel mailing list