[alsa-devel] [patch 1/2] ALSA: oxfw: some signedness bugs

[Dan Carpenter]

On Sat, Dec 13, 2014 at 02:06:59PM +0900, Takashi Sakamoto wrote:
> On Dec 13 2014 04:27, Dan Carpenter wrote:
> > This code tends to use unsigned variables by default and it causes
> > signedness bugs when we use negative variables for error handling.
> > The "i" and "j" variables are used to iterated over small positive
> > values and so they should be type "int".  The "len" variable doesn't
> > *need* to be signed but it should be signed to make the code easier to
> > read and audit.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> Thanks, but I prefer to use 'unsigned int' for loop counter, like the
> other drivers.

Unthinking use of unsigned int every where is a kind of leprosy.  It
just makes the code hard to read and it causes bugs.

regards,
dan carpenter