[alsa-devel] [PATCH 1/3] ASoC: codecs: wm8904: add dt ids table

[Mark Brown]

On Thu, Dec 11, 2014 at 11:14:39AM +0800, Bo Shen wrote:

> +static const struct of_device_id wm8904_of_match[] = {
> +	{ .compatible = "wlf,wm8904", },
> +	{ .compatible = "wlf,wm8912", },
> +	{ .compatible = "wlf,wm8918", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, wm8904_of_match);
> +
>  static struct i2c_driver wm8904_i2c_driver = {
>  	.driver = {
>  		.name = "wm8904",
>  		.owner = THIS_MODULE,
> +		.of_match_table = wm8904_of_match,

I'm not seeing anything here that ensures that devtype is set correctly
when probing using the OF IDs - currently we rely on i2c->driver_data.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141212/d2eece05/attachment.sig>