[alsa-devel] [patch] ALSA: pcxhr: NULL dereference on probe failure

Dan Carpenter dan.carpenter at oracle.com
Wed Dec 10 14:26:21 CET 2014


"card" is NULL if snd_card_new() fails.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c
index a602930..c6092e4 100644
--- a/sound/pci/pcxhr/pcxhr.c
+++ b/sound/pci/pcxhr/pcxhr.c
@@ -1638,7 +1638,7 @@ static int pcxhr_probe(struct pci_dev *pci,
 				   0, &card);
 
 		if (err < 0) {
-			dev_err(card->dev, "cannot allocate the card %d\n", i);
+			dev_err(&pci->dev, "cannot allocate the card %d\n", i);
 			pcxhr_free(mgr);
 			return err;
 		}


More information about the Alsa-devel mailing list