[alsa-devel] [PATCH] ASoC: samsung: Fix non-DT use of I2S controller

[Padma Venkat]

Hi Mark,

On 12/8/14, Mark Brown <broonie at kernel.org> wrote:
> On Mon, Dec 08, 2014 at 10:21:52AM +0530, Padma Venkat wrote:
>> On 12/6/14, Mark Brown <broonie at kernel.org> wrote:
>
>> > +	}, {
>> > +		.name		= "samsung-i2sv4",
>> > +		.driver_data	= (kernel_ulong_t)&i2sv5_dai_type_i2s1,
>
>> I think here you need to use i2sv5_dai_type because
>> i2sv5_dai_type_i2s1 is introduced for exynos7 on which the i2s1 is of
>> type v5 but with slightly modified bit offsets.
>
> OK, though I presume that's wrong too (otherwise it should be v4).
>
Yes. It does not have secondary dai, internal DMA, reset control. It
has only 5.1ch support. Register offsets are similar to i2sv3_regs. So
I think one V4 dai type with name "samsung,s3c64xx-i2s" is required.

Thanks
Padma