[alsa-devel] [PATCH 5/5] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

Mark Brown broonie at kernel.org
Wed Dec 3 18:38:54 CET 2014


On Wed, Dec 03, 2014 at 04:39:14PM +0000, Andrew Jackson wrote:
> If the FIFOs aren't flushed, the left/right channels may be swapped:
> this may occur if the FIFOs are not empty when the streams start.

>  	/* Iterate over set of channels - independently controlled. */
>  	do {
>  		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> +			i2s_write_reg(dev->i2s_base, TXFFR, 1);

This is an example of the problem with putting fixes at the end of the
series - this can't be applied without your previous change to add the
support for more channels (which is a new feature).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141203/ea3a129a/attachment-0001.sig>


More information about the Alsa-devel mailing list