[alsa-devel] ASoC: core: Call mute for cpu dais as well

[Lars-Peter Clausen]

On 12/02/2014 06:13 PM, Babu, Ramesh wrote:
>> This is a semi-automatic email about new static checker warnings.
>>
>> The patch ae11601b80b9: "ASoC: core: Call mute for cpu dais as well"
>> from Oct 15, 2014, leads to the following Smatch complaint:
>>
>> sound/soc/soc-pcm.c:777 soc_pcm_prepare()
>> 	 error: we previously assumed 'cpu_dai->driver->ops' could be null
>> (see line 755)
>>
>> sound/soc/soc-pcm.c
>>     754
>>     755		if (cpu_dai->driver->ops && cpu_dai->driver->ops->prepare)
>> {
>>                      ^^^^^^^^^^^^^^^^^^^^ I don't think this can be NULL.  Probably
>> we should remove this check.
> Nope. ops can be NULL.

It can't. If it is the core will update it to point to null_dai_ops.

- Lars